-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(): update to NodeJS 10 or OpenSSL 1.1.0 (closes #167) #169
Conversation
Confirmed working well on macOS 10.13.4, node v10.2.1. Thanks, @jkuri! @JoshKaufman What can users do to help get this ready for merge? |
Working perfectly on Linux, with latest Node 10.2.1 and NPM 6.1.0
|
It works, so merge it please, production code won't run because I can't build this on a Compute Engine instance. |
Thank you! |
@JoshKaufman thanks for merging, can you also publish a new version to |
I'm also waiting for publishing 😂😂😂 |
Please @JoshKaufman can publish? Or alternatively, give others rights to do so? It's highly preferred from forking and maintaining that. |
Will this ever make it to npm? It's much harder to do CI builds without there being a dependable npm source for this fix. |
@quartzjer as the new maintainer, could you please do a publish to NPM? It can't be so hard... |
I made it backward compatible with previous NodeJS/OpenSSL versions.